Authenticated user aware notebook storage layer #998
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khalidhuseynov
changed the title
khalidhuseynov
force-pushed
the
update-api/pass-auth-info-to-repo
branch
10 times, most recently
from
049c663 to
1cfba76
Compare
Member
Author
|
somehow selenium tests keep error with which is not related, will be reopening. |
khalidhuseynov
force-pushed
the
update-api/pass-auth-info-to-repo
branch
7 times, most recently
from
e0109f7 to
0b2d122
Compare
Member
|
LGTM I have tested and works well for me. Will be useful to get it into 0.6 release (especially if #836 is also in 0.6, as methods are added in the NotebookServer, which will have impact on this PR). |
Member
|
Thanks @khalidhuseynov for the improvement. |
added 9 commits
June 16, 2016 22:19
list(null) basically means that the callee of list isn't from outside, but some zeppelin routine code e.g. tests, or initialization mechanism, can be further improved
added 15 commits
June 16, 2016 22:25
khalidhuseynov
force-pushed
the
update-api/pass-auth-info-to-repo
branch
from
0b2d122 to
e628fa8
Compare
khalidhuseynov
force-pushed
the
update-api/pass-auth-info-to-repo
branch
from
e628fa8 to
b91e78a
Compare
Member
Author
|
rebased from master |
Contributor
|
LGTM...I have tested and works well for me. |
asfgit
pushed a commit
that referenced
this pull request
Jun 18, 2016
This PR is to make available information on the currently authenticated user(subject) in the Notebook storage level. It can be used for multiple purposes (ACL, login to third parties, etc.) once storage layer is user aware. It basically updates NotebookRepo api with additional user info Improvement * [x] - add authInfo(subject) to list() * [x] - add authInfo(subject) to get() * [x] - add authInfo(subject) to save() * [x] - add authInfo(subject) to remove() storage layer should be working as before with and without authenticated user, green CI * Does the licenses files need update? No * Is there breaking changes for older versions? not breaking, but some api changes * Does this needs documentation? No Author: Khalid Huseynov <[email protected]> Closes #998 from khalidhuseynov/update-api/pass-auth-info-to-repo and squashes the following commits: b91e78a [Khalid Huseynov] propagate subject to versioning api f3bae60 [Khalid Huseynov] fix checkstyle bb57eae [Khalid Huseynov] address changes for job management pr after rebasing 8b48577 [Khalid Huseynov] fix test after master merge a69d04f [Khalid Huseynov] add descriptions to NotebookRepo interface 0bf40b3 [Khalid Huseynov] propagate changes to tests aa95537 [Khalid Huseynov] propagate changes upstream a0ebd14 [Khalid Huseynov] add subject to checkpoint signature of all repos 50ba14a [Khalid Huseynov] add subject to NotebookRepo api bd0a290 [Khalid Huseynov] propagate changes to tests 91426af [Khalid Huseynov] propagate changes with remove upstream 232d1af [Khalid Huseynov] propagate remove(noteId, subject) to all repo signatures d0d7b98 [Khalid Huseynov] add subject to repo remove api 21f189d [Khalid Huseynov] propagate changes to save into tests b5f88e2 [Khalid Huseynov] propagate subject changes upstream b7b007a [Khalid Huseynov] add subject to all repo signatures 0a4a8d2 [Khalid Huseynov] add subject to repo save api 8fdaed3 [Khalid Huseynov] propagate changes to tests 3ea544d [Khalid Huseynov] propagate changes up to Notebook 91fc500 [Khalid Huseynov] modify all repo signatures with get(noteId, subject) fb93e22 [Khalid Huseynov] add subject to repo api for get 7d964c7 [Khalid Huseynov] propagate list(subject) to tests 8e7d8bd [Khalid Huseynov] propagate changes to list up f66dc1b [Khalid Huseynov] modify all repo signatureswith list(subject) 1c29bee [Khalid Huseynov] change api for repo list (cherry picked from commit 4a0dce5) Signed-off-by: Lee moon soo <[email protected]>
Leemoonsoo
added a commit
to Leemoonsoo/zeppelin
that referenced
this pull request
Jun 22, 2016
1 task
asfgit
pushed a commit
that referenced
this pull request
Jun 22, 2016
### What is this PR for? There were some mistake merging #998 into branch-0.6 ### What type of PR is it? Hot Fix ### Todos * [x] - fix mistake Author: Lee moon soo <[email protected]> Closes #1065 from Leemoonsoo/branch-0.6-fix and squashes the following commits: 54cd601 [Lee moon soo] Fix merge mistake from #998
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR is to make available information on the currently authenticated user(subject) in the Notebook storage level. It can be used for multiple purposes (ACL, login to third parties, etc.) once storage layer is user aware. It basically updates NotebookRepo api with additional user info
What type of PR is it?
Improvement
Todos
What is the Jira issue?
How should this be tested?
storage layer should be working as before with and without authenticated user, green CI
Screenshots (if appropriate)
Questions: